-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: more details about desc validity errors during upgrades #104048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
knz
force-pushed
the
20230529-precond-checks
branch
from
May 29, 2023 16:10
946a7e6
to
f201127
Compare
Before this patch: ``` ignoring invalid descriptor ‹defaultdb.public.test_upload_payload› (‹107›) with error because it looks like known userfile-related corruption: ‹mutation job 800353382687703041: job not found› ``` which resulted after redaction into: ``` ignoring invalid descriptor ‹×› (‹×›) with error because it looks like known userfile-related corruption: ‹×› ``` After this patch: ``` ignoring invalid descriptor ‹defaultdb.public.test_upload_payload› (107) with error because it looks like known userfile-related corruption: mutation job 800353382687703041: job not found ``` which results after redaction into: ``` ignoring invalid descriptor ‹×› (107) with error because it looks like known userfile-related corruption: mutation job 800353382687703041: job not found ``` Release note (cli change): Failures during descriptor validity checks during cluster upgrades are now more detailed in redacted logs.
knz
force-pushed
the
20230529-precond-checks
branch
from
May 29, 2023 16:14
f201127
to
f9b7783
Compare
postamar
approved these changes
May 29, 2023
postamar
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102757.
Informs #104049.
Epic: CRDB-27642.
Before this patch:
which resulted after redaction into:
After this patch:
which results after redaction into:
Release note (cli change): Failures during descriptor validity checks
during cluster upgrades are now more detailed in redacted logs.
Release justification: better troubleshootability